Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Export: Add missing schema attributes #39575

Closed
scruffian opened this issue Mar 18, 2022 · 2 comments · Fixed by #39775
Closed

Theme Export: Add missing schema attributes #39575

scruffian opened this issue Mar 18, 2022 · 2 comments · Fixed by #39775
Assignees
@scruffian
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

Description

The theme.json file is missing this from the original theme:

Step-by-step reproduction instructions

  1. Export a theme from the Site Editor
  2. Check for the existence of the $schema and appearanceTools attributes in the theme.json.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@scruffian scruffian added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 18, 2022
@scruffian scruffian mentioned this issue Mar 18, 2022
Merged
@pbking
Copy link
Contributor

pbking commented Mar 18, 2022

#39464 was opened to address absent appearanceTools though $schema wasn't mentioned.

@scruffian scruffian changed the title Theme Export: Add missing scheme attributes Theme Export: Add missing schema attributes Mar 18, 2022
@scruffian scruffian mentioned this issue Mar 18, 2022
Merged
@scruffian
Copy link
Contributor Author

Fixed in #39590

@scruffian scruffian mentioned this issue Mar 25, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 25, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scruffian scruffian

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme Export: If the theme declares a version number then add a schema WordPress/gutenberg
3 participants
@pbking @scruffian @priethor