Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pathway to rename Template Parts from the toolbar #38908

Open
jameskoster opened this issue Feb 18, 2022 · 3 comments
Open

Add a pathway to rename Template Parts from the toolbar #38908

jameskoster opened this issue Feb 18, 2022 · 3 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Currently the only way to rename a template part is via the Advanced panel in the Inspector:

Screenshot 2022-02-18 at 10 30 52

It may be worth offering a pathway to do this from the block toolbar, for situations where the Inspector is closed. It's not a frequent flow, so the more menu seems like a good home for such an option:

Screenshot 2022-02-18 at 10 28 17

Clicking "Rename" could invoke the same modal we currently use for naming template parts on creation:

Screenshot 2022-02-18 at 10 29 21

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Full Site Editing [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 18, 2022
@jasmussen
Copy link
Contributor

Realizing that the ´[Icon] Header` part of the toolbar currently opens a dropdown, my first instinct would be to have a rename feature in context of that label.

One thing we know we want to get to, is to refactor the transforms menu. As a place that can hold block, pattern, and style transformations all in one place, it could (should?) be one of the first things you check for a block when you want to explore alternate designs.

If the transforms menu became more of a destination, would it provide a spot for renaming? What might it look like?

@jameskoster
Copy link
Contributor Author

Yes I think that makes sense. All template part specific actions (swapping, editing, detaching) could potentially live there.

@strarsis
Copy link
Contributor

+1, also a theme template part overridden by the user will keep the old template part name, even if the theme changes it (as in theme.json, templateParts[]/name).

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants