Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Inconsistency when replacing media on cover block #38672

Open
mchowning opened this issue Feb 9, 2022 · 0 comments
Open

Mobile: Inconsistency when replacing media on cover block #38672

mchowning opened this issue Feb 9, 2022 · 0 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@mchowning
Copy link
Contributor

mchowning commented Feb 9, 2022

What problem does this address?

On the mobile apps, the flows for replacing media on the cover block are inconsistent between videos and images. In particular, with images, the most straightforward way to replace the media is by tapping on the edit icon on the top right of the cover block.

Image After clicking the edit icon
Screen Shot 2022-02-09 at 10 42 43 AM Screen Shot 2022-02-09 at 10 42 47 AM

When the cover block is displaying a video, however, that option is not available.

Instead, you must follow a far more indirect route:

1. Tap the block settings "cog" 2. Clear the media 3. Add the new media to the (now-empty block) by either (a) tapping the now-present edit icon in the top-right, or (b) tapping the cog a second time to get the "Add image or video option"
Screen Shot 2022-02-09 at 10 45 56 AM Screen Shot 2022-02-09 at 10 46 37 AM Screen Shot 2022-02-09 at 10 50 26 AM

And then proceed to add a new media item to the now-empty cover block.

What is your proposed solution?

I think we should include the add media button in the top right of the block when either a video or image is being displayed, not just when an image is being displayed. For videos it shouldn't have the edit option (since we don't have the ability to edit videos currently), so it should probably just directly open the replace modal since that would be the only option.

@mchowning mchowning added [Type] Enhancement A suggestion for improvement. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 9, 2022
@mchowning mchowning changed the title [Mobile] Inconsistency when replacing media on cover block Mobile: Inconsistency when replacing media on cover block Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant