-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Comments Query Loop] [Query Loop] Consider using a generic Avatar block #38456
Comments
Hey @c4rl0sbr4v0 I'm all in favour of working out a solution here - I only wonder why 7 of has have been assigned to this issue? 🤔 |
I agree. It was suggested that there could be a user block with variations, but there was no interest or buy-in for that approach. |
That is my fault. I did that so you get notified and can discuss it 😅 |
Variations seem like it could work and is worth exploring for blocks like |
What problem does this address?
Right now, we have on Gutenberg two different blocks:
We are working in parallel, but, we are also taking the other's code quite a lot. Both are really similar, being the only difference in the data we fetch to get the Avatar (post author ID vs post comment ID), but both are just user ID.
What is your proposed solution?
Explore if it makes sense to have only a Core Avatar Block and absorb the complexity of deciding which Avatar should be displayed on each case. This way we can:
Excalidraw link
CC: @michalczaplinski , @carolinan , @ntsekouras , @gziolo , @DAreRodz , @mtias
The text was updated successfully, but these errors were encountered: