Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block: Block doesn't get selected after tapping on it when is unselected and empty #38444

Closed
fluiddot opened this issue Feb 2, 2022 · 0 comments · Fixed by #53127
Closed

Gallery block: Block doesn't get selected after tapping on it when is unselected and empty #38444

fluiddot opened this issue Feb 2, 2022 · 0 comments · Fixed by #53127
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Feb 2, 2022

Description

When tapping on a Gallery block that is empty and not selected, the media picker menu pops up, but dismissing the picker doesn't set the block as selected.

Step-by-step reproduction instructions

  1. Add a Gallery block (do not add any images to it).
  2. Select a different block or the post/page title.
  3. Tap on the Gallery block.
  4. Observe that the media picker is displayed.
  5. Dismiss the media picker.
  6. Observe that the block doesn't get selected.

Expected behaviour

The Gallery block should be selected if the user taps on it in any case.

Actual behaviour

The Gallery block doesn't get selected after tapping on it if it's unselected and empty.

Screenshots or screen recording (optional)

ios-media-blocks.mp4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 11
  • Operating system: iOS 15.1
  • WordPress app version: 19.0
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Gallery Affects the Gallery Block - used to display groups of images labels Feb 2, 2022
@hypest hypest added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Feb 2, 2022
@fluiddot fluiddot mentioned this issue May 5, 2023
Merged
@dcalhoun dcalhoun mentioned this issue Jul 28, 2023
Merged
@SiobhyB SiobhyB mentioned this issue Aug 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Select Gallery block when adding media WordPress/gutenberg
2 participants
@hypest @fluiddot