Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight text button: Undo applying a color breaks the undo history #38084

Closed
fluiddot opened this issue Jan 19, 2022 · 2 comments · Fixed by #57650
Closed

Highlight text button: Undo applying a color breaks the undo history #38084

fluiddot opened this issue Jan 19, 2022 · 2 comments · Fixed by #57650
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

Description

After applying a color via the Highlight text button, the next undo actions are removed from history after undoing applying the color.

Step-by-step reproduction instructions

  1. Add a Paragraph block.
  2. Type some text.
  3. Apply bold/italic/strikethrough formats to some words.
  4. Select a word and tap on the Highlight text button (A).
  5. Select a color.
  6. Execute other actions that can be undone (i.e. apply bold/italic/strikethrough formats to other words).
  7. Tap on the undo button until it reaches the color apply action.
  8. Observe that the undo history gets deleted and that previous actions can't be redone.

Expected behaviour

Executing undo actions shouldn't delete the undo history.

Actual behaviour

Undoing color apply action deletes the undo history.

Screenshots or screen recording (optional)

android-text-color-undo-history.mp4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: Samsung Galaxy S20 FE
  • Operating system:
  • WordPress app version:
@fluiddot fluiddot added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended labels Jan 19, 2022
@mchowning
Copy link
Contributor

I was also able to recreate this on the 18.9 version of the app, so it is not a regression since that release.

@mchowning mchowning added the [Priority] High Used to indicate top priority items that need quick attention label Jan 20, 2022
@geriux geriux self-assigned this Mar 7, 2022
@geriux geriux removed their assignment Mar 15, 2022
@fluiddot
Copy link
Contributor Author

fluiddot commented Dec 22, 2023

I managed to reproduce the issue in version 23.9, although it doesn't happen consistently. For some reason, it's easier to reproduce it when performing the undo/redo actions quickly. That said, I'd advocate changing the priority to Low as seems to have less impact than it was when the issue was created.

@fluiddot fluiddot added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later and removed [Priority] High Used to indicate top priority items that need quick attention labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants