Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Link functionality hidden by WP Admin left menu in Paragraph block #3637

Closed
jeffpaul opened this issue Nov 23, 2017 · 2 comments
Closed
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@jeffpaul
Copy link
Member

Issue Overview

The leftmost edge of the Link modal within the Paragraph block appears behind the WP Admin left menu when clicking on text on the leftmost edge of the Paragraph block.

Steps to Reproduce (for bugs)

  1. Cloned a previous Gutenberg post.
  2. Clicked on link text within an existing Paragraph block in attempts to edit the URL.
  3. Unable to see the Edit icon.
    Tested on macOS 10.13.1 using Firefox 57.0 (20171112125346) on the Make/Core WordPress install.

Expected Behavior

The Link modal should appear fully within the editing area so that link details can easily be edited.

Current Behavior

The Link modal appears hidden behind the WP Admin left menu and makes it difficult to edit the link details.

Possible Solution

The Link modal could have its leftmost boundary set a certain number of pixels past the rightmost edge of the WP Admin left menu.

Screenshots / Video

image

@hedgefield
Copy link

I would just keep the modal in the same place regardless of which word you are linking, like the permalink modal (but still below the block).

screen shot 2017-11-24 at 12 53 43

@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Component] TinyMCE Needs Design Feedback Needs general design feedback. labels Nov 24, 2017
@karmatosed
Copy link
Member

I am going to link this to #4209 and close. There are a few issues with the link overlay we should consider.

@hedgefield I think we're at a crossroads with what we do, should the link be contextual or should it be consistently placed. I'd like us to explore what other designs do and ponder that approach in the linked issue.

@designsimply designsimply added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed Needs Design Feedback Needs general design feedback. labels Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

5 participants