Post Template returns empty string when no results found

[iandunn]

Description

I expected index.php to return No results found like edit.js does, but it returns an empty string.

gutenberg/packages/block-library/src/post-template/index.php

Lines 39 to 41 in 9a2ae8d

	if ( ! $query->have_posts() ) {
	return '';
	}

gutenberg/packages/block-library/src/post-template/edit.js

Lines 143 to 145 in 9a2ae8d

	if ( ! posts.length ) {
	return <p { ...blockProps }> { __( 'No results found.' ) }</p>;
	}

Step-by-step reproduction instructions

1. Setup a FSE theme
2. Add a search.html template w/ the following:

   <!-- wp:query {"queryId":1,"query":{"perPage":10,"postType":"any","inherit":true}} -->
   	<div class="wp-block-query">
   		<!-- wp:post-template -->
   			<!-- wp:post-title {"level":5,"isLink":true} /-->
   
   			<!-- wp:post-excerpt /-->
   		<!-- /wp:post-template -->
   	</div>
   <!-- /wp:query -->

3. Browse to /?s=supercalifragilisticexpialidocious

Screenshots, screen recording, code snippet

No response

Environment info

• Gutenberg 1876833
• Core 5.8.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[iandunn]

Related: #29521

[iandunn]

Also related: #33476

[ramonjd]

I think this issue should be part of a bigger drive to make the "no results" state configurable.

Here are two issues that raise this:

• Query block: Add a configurable "no posts found" state #36609
• Allow customizing the no-results behavior of the query block #27302

I threw up #38437 in haste, thinking that showing a message on the frontend, one that is consistent with the editor experience, would be a good thing.

But upon reflection I asked myself whether displaying text that isn't editable is something that might irk users, and also go against the spirit of theme editor. Do you think it might be best to wait until we deliver an editable solution?

[carolinan]

Can this issue be closed as fixed by #38806 ?

[iandunn]

I think that'll work, thanks!