Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: Missing border when initial value is undefined #35382

Closed
Tracked by #34345
mirka opened this issue Oct 6, 2021 · 2 comments
Closed
Tracked by #34345

ToggleGroupControl: Missing border when initial value is undefined #35382

mirka opened this issue Oct 6, 2021 · 2 comments
Assignees
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Oct 6, 2021

Description

When the initial value of a ToggleGroupControl is undefined, there is a missing border after the first item.

Step-by-step reproduction instructions

  <ToggleGroupControl value={undefined} >
    <ToggleGroupControlOption
      key="foo"
      label="foo"
      value="foo"
    />
    <ToggleGroupControlOption
      key="bar"
      label="bar"
      value="bar"
    />
  </ToggleGroupControl>

Screenshots, screen recording, code snippet

ToggleGroupControl with missing border after first item

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mirka mirka added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Feature] Component System WordPress component system labels Oct 6, 2021
@amustaque97
Copy link
Member

I will be working on this issue. Will link a PR soon 😄

@ntsekouras ntsekouras removed the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 7, 2021
@ntsekouras
Copy link
Contributor

Fixed by: #35409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants