Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolsPanel: Dimensions panel appears empty at first when duplicating a block with Dimensions #34724

Closed
andrewserong opened this issue Sep 10, 2021 · 0 comments · Fixed by #34726
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Sep 10, 2021

Description

While testing #34065, I noticed that if we duplicate a block that uses the Dimensions Panel, when the block is copied, the Dimensions panel appears to be empty. If you click away from the panel and back to it, it is no longer empty.

A possible culprit to investigate: when we duplicate the block, perhaps there isn't a clientId available yet when registering the ToolsPanel?

Step-by-step reproduction instructions

  1. In a post, add a block that uses the Dimensions panel (E.g. a Group block) and set a value for padding
  2. Copy the block
  3. Paste the block elsewhere in your post
  4. Notice that the Dimensions panel appears to be empty
  5. Click away to another block, then click back to the block you duplicated
  6. Notice that the Dimensions panel is no longer empty

Screenshots, screen recording, code snippet

Screenshot from testing with the Cover block in #34065

cover-block-tools-panel-sml

Environment info

TT1-Blocks theme
Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Sep 10, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant