Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url-details endpoint doesn't look for og:description when searching for a description #33754

Closed
Tracked by #35073
getdave opened this issue Jul 29, 2021 · 0 comments · Fixed by #35875
Closed
Tracked by #35073

url-details endpoint doesn't look for og:description when searching for a description #33754

getdave opened this issue Jul 29, 2021 · 0 comments · Fixed by #35875
Assignees
@Mamaduka @getdave @hellofromtonya
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) REST API Interaction Related to REST API [Status] In Progress Tracking issues with work in progress

Comments

@getdave
Copy link
Contributor

getdave commented Jul 29, 2021

Currently the url-details REST API endpoint in Gutenberg does not find og:description when searching for a valid "description" in the remote site's HTML response.

Currently it looks for meta description only.

We should modify this to also find og:description.

@hellofromtonya When testing this I've realised that the url-details endpoint doesn't look for og:description when searching for a description. How difficult would it be to update that?

Originally posted by @getdave in #33086 (comment)
@getdave getdave added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) REST API Interaction Related to REST API labels Jul 29, 2021
@fabiankaegy fabiankaegy mentioned this issue Sep 23, 2021
Open
39 tasks
@Mamaduka Mamaduka mentioned this issue Oct 22, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

@getdave getdave

@hellofromtonya hellofromtonya

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) REST API Interaction Related to REST API [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URL Details: Update regex to include og:description WordPress/gutenberg
3 participants
@Mamaduka @getdave @hellofromtonya