Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen reader text in block library shouldn't be visible on focus #33724

Open
walbo opened this issue Jul 28, 2021 · 0 comments
Open

Screen reader text in block library shouldn't be visible on focus #33724

walbo opened this issue Jul 28, 2021 · 0 comments
Assignees
@walbo
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress

Comments

@walbo
Copy link
Member

walbo commented Jul 28, 2021

Description

#30141 added screen-reader-text in the common block library CSS.

:focus on screen-reader-text has some unintended effects on some other focusable elements in core, and users' websites could have something similar on the front end. See core ticket https://core.trac.wordpress.org/ticket/53803

The focus styles are intended mainly for skip links, not just anything with the class.

cc @sabernhardt

WordPress information

  • WordPress version: 5.8
  • Gutenberg version: Not installed
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Desktop
  • Operating system: Mac OS Big Sur
  • Browser: Chrome 92
@walbo walbo mentioned this issue Jul 28, 2021
Closed
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 28, 2021
@skorasaurus skorasaurus added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walbo walbo

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block library: Remove focus style on screen-reader-text walbo/gutenberg
2 participants
@skorasaurus @walbo