Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HTML Element" option for Columns and Columns blocks #33343

Open
justintadlock opened this issue Jul 10, 2021 · 2 comments
Open

"HTML Element" option for Columns and Columns blocks #33343

justintadlock opened this issue Jul 10, 2021 · 2 comments
Labels
[Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement.

Comments

@justintadlock
Copy link
Contributor

Both the Columns and its inner Column block will often be used for structural sections on the page. Users/Themers should be able to set the HTML element used.

Currently, both blocks are wrapped in a <div>. However, <main>, <section>, <aside>, and <article> will make sense in various use cases.

<header> and <footer> could potentially make sense for the outer Columns block, but I'd like to focus on getting the other options in for sure.

@kraftner
Copy link

Related issues #15000 #27092

@skorasaurus skorasaurus added [Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement. labels Jul 11, 2021
@carolinan
Copy link
Contributor

I wonder if it would also make sense to move the HTML filter to its own separate control.
It is used but slightly differently for the group, template part and query blocks.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 29, 2021
@carolinan carolinan removed the [Status] In Progress Tracking issues with work in progress label Apr 28, 2022
@carolinan carolinan removed their assignment Apr 28, 2022
@carolinan carolinan self-assigned this May 18, 2022
@carolinan carolinan removed their assignment Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants