Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide LinkControl rich preview placeholders if no content available #32547

Closed
Tracked by #35073
getdave opened this issue Jun 9, 2021 · 1 comment
Closed
Tracked by #35073

Hide LinkControl rich preview placeholders if no content available #32547

getdave opened this issue Jun 9, 2021 · 1 comment
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented Jun 9, 2021 •
edited
Loading

In #31464 (comment), when discussing rich previews, @javierarce suggested hiding the placeholders if there is no data returned for that placeholder from the API.

Here's the Figma for that https://www.figma.com/file/OXOmvYcX0Gpwgt7FB5LlKA/Rich-URL-metadata?node-id=0%3A1

This will need implementing as a follow up once In #31464 is merged.
@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Jun 9, 2021
@getdave getdave self-assigned this Jun 9, 2021
@getdave getdave changed the title Hide placeholders if no content available Hide LinkControl rich preview placeholders if no content available Jun 9, 2021
@fabiankaegy fabiankaegy mentioned this issue Sep 23, 2021
Open
39 tasks
@getdave
Copy link
Contributor Author

getdave commented Sep 23, 2021

This is already in place.

Screenshot 2021-09-23 at 10 22 14

@getdave getdave closed this as completed Sep 23, 2021
@getdave getdave mentioned this issue Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdave