Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Block: Prevent background scrolling when mobile menu overlay is active #32206

Closed
kjellr opened this issue May 25, 2021 · 0 comments · Fixed by #32269
Closed

Navigation Block: Prevent background scrolling when mobile menu overlay is active #32206

kjellr opened this issue May 25, 2021 · 0 comments · Fixed by #32269
Assignees
@jasmussen
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented May 25, 2021

When the navigation's responsive navigation is active and the overlay is visible, it's possible to scroll the background. To prevent users from getting disoriented on the page, we should prevent scrolling of the background when the navigation is open.

Screenshot:

scrolling

Tested with Gutenberg 10.7.0-rc.1
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels May 25, 2021
@jasmussen jasmussen mentioned this issue May 27, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lock the document from scrolling when the modal is open. WordPress/gutenberg
2 participants
@kjellr @jasmussen