Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block shows toolbar button to "Add text over image" even when core/cover block is nor registered #32094

Closed
fabiankaegy opened this issue May 21, 2021 · 1 comment · Fixed by #32666
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@fabiankaegy
Copy link
Member

Description

The Core Image Block recently added an option to "Add text over image" which under the hood transforms the Image block to a Cover Block. This button still gets rendered in the Blocks Toolbar in cases where the Cover Block is not registered.

Instances where this can happen is when a site uses white / blacklisting.

Expected behaviour

When the Core Cover block is not registered the button should not show anymore.

Actual behaviour

When the Core Cover block is not registered the button does snow but doesn't do anything.

WordPress information

  • WordPress version: "5.7.2"
  • Gutenberg version: "Not installed"
  • Are all plugins except Gutenberg deactivated? "Yes"
  • Are you using a default theme (e.g. Twenty Twenty-One)? "Yes"
@talldan talldan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended labels May 25, 2021
@Mamaduka
Copy link
Member

I pushed the PR to fix issue #32666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants