Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block placeholder is invisible against black a background #31841

Closed
kjellr opened this issue May 14, 2021 · 2 comments · Fixed by #31875
Closed

Navigation block placeholder is invisible against black a background #31841

kjellr opened this issue May 14, 2021 · 2 comments · Fixed by #31875
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented May 14, 2021

If you place the navigation block on top of a blank background, its deselected placeholder is invisible:

navigation

To reproduce:

<!-- wp:group {"style":{"color":{"background":"#000000"}}} -->
<div class="wp-block-group has-background" style="background-color:#000000"><!-- wp:navigation {"orientation":"horizontal"} /--></div>
<!-- /wp:group -->

Seen in a few block based themes, incl. TT1 Blocks and emptytheme.

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels May 14, 2021
@kjellr
Copy link
Contributor Author

kjellr commented May 14, 2021

cc @jasmussen since I know you've been iterating on this placeholder. I see that it's supposed to pick up the currentColor, but it doesn't seem to be working for me in this case.

This issue comes up in a few of the patterns in #31610:

Screen Shot 2021-05-14 at 3 22 50 PM

Both of those have nav block placeholders on the right side, but they're impossible to see. I expected something more like this:

Screen Shot 2021-05-14 at 3 24 54 PM

@jasmussen
Copy link
Contributor

Thanks for the ping, I'll take a look as soon as I get a moment. It might be an effect of the recently merged burger menu.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants