Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Editor: Move locations modal state into ManageLocations component #31837

Closed
Mamaduka opened this issue May 14, 2021 · 2 comments · Fixed by #32078
Closed

Navigation Editor: Move locations modal state into ManageLocations component #31837

Mamaduka opened this issue May 14, 2021 · 2 comments · Fixed by #32078
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@Mamaduka
Copy link
Member

What problem does this address?

Currently, the modal state is managed by the main useNavigationEditor hook. I don't think there's a need for this now.

What is your proposed solution?

Move modal state to ManageLocations component and manage it locally.

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Edit Navigation labels May 14, 2021
@Mamaduka Mamaduka self-assigned this May 14, 2021
@getdave
Copy link
Contributor

getdave commented May 17, 2021

I don't think there's a need for this now.

Could you expand on this a little bit? What makes you feel there is no longer a need?

@Mamaduka
Copy link
Member Author

Sorry, I should've used a different sentence here. I don't know why this was done initially, but there's no need to manage modal state in useNavigationEditor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants