Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esc and Enter keys: Modify behavior in Customizer > Widgets #31730

Closed
critterverse opened this issue May 11, 2021 · 1 comment · Fixed by #32175
Closed

Esc and Enter keys: Modify behavior in Customizer > Widgets #31730

critterverse opened this issue May 11, 2021 · 1 comment · Fixed by #32175
Assignees
@kevin940726
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@critterverse
Copy link
Contributor

This issue is for taking a look at the keyboard behavior for Esc and Enter keys within the Customizer Widgets screen.

Since the editor and Customizer have different behaviors for these keys, I wonder if we could try a hybrid approach:

  • If you have a block selected, Esc and Enter toggles between Select and Edit mode (default editor behavior)
  • If you don’t have a block selected, Esc and Enter takes you back a screen (default Customizer behavior)

These tweaks would be especially helpful re: the editing flow for legacy widgets that was merged in #30889.
@critterverse critterverse added the [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. label May 11, 2021
@critterverse critterverse mentioned this issue May 12, 2021
Closed
This was referenced May 19, 2021
Merged
Closed
@talldan talldan added the [Type] Bug An existing feature does not function as intended label May 20, 2021
@talldan
Copy link
Contributor

talldan commented May 20, 2021

Labelling as a bug now that we're approaching the point where the editors are considered stable. Select/navigation mode should be usable.

The customizer escape key handling is also causing an issue with popovers as described in the duplicate - #31972.

@kevin940726 kevin940726 self-assigned this May 24, 2021
@kevin940726 kevin940726 mentioned this issue May 25, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix escape key events in customizer closing the editor WordPress/gutenberg
3 participants
@talldan @kevin940726 @critterverse