Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Link: Allow setting as icon-only #31688

Open
Tracked by #35521
jasmussen opened this issue May 11, 2021 · 3 comments
Open
Tracked by #35521

Home Link: Allow setting as icon-only #31688

jasmussen opened this issue May 11, 2021 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

What problem does this address?

Extracting from the recently added Home Link block, it would be interesting to consider a setting to turn the link into a home icon, as that is a common use case for navigation.

What is your proposed solution?

Add a segmented control to the Home Link block sidebar, to allow choosing between Label, Icon, or Icon plus label:

117638532-36040f80-b183-11eb-9650-c04101021ca8

If folks choose an icon only version, we'd maybe need to allow folks to edit alt-text. That could be an alt-text input field contextually surfaced in the inspector, defaulting to "Home".

@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

I think this would be really nice and could also be extended (credits to @paaljoachim ) to other menu items (like a phone or email for contact).

We would have to think about the icons though. You don't want to load too many icons as the libraries can get out of hand, but if you don't have enough icons, you get the Bootstrap issue where everyone directly sees the tool you used for the website.

An idea would be to add an icon block, and give people the choice of one library between a few icon libraries on install (or in the settings).

@paaljoachim
Copy link
Contributor

Linking in the Icons block issue. #16484

@jameskoster
Copy link
Contributor

I think this would be really nice and could also be extended (credits to @paaljoachim ) to other menu items (like a phone or email for contact).

That's an interesting idea. What would it mean for the Social Icons block... could that become a pattern for the Navigation block?

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants