Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing block: Displays undefined block name for some unsupported blocks #31545

Closed
fluiddot opened this issue May 6, 2021 · 3 comments · Fixed by #31743
Closed

Missing block: Displays undefined block name for some unsupported blocks #31545

fluiddot opened this issue May 6, 2021 · 3 comments · Fixed by #31743
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

fluiddot commented May 6, 2021

Description

The missing block is not showing the proper name of all unsupported blocks.

I checked the recently merged commits and looks like this bug was introduced in this PR.

NOTE: This issue happens on both platforms (iOS + Android).

Step-by-step reproduction instructions

  1. Add some unsupported blocks
  2. Add a Table block, which is also unsupported (use the example below)
<!-- wp:table -->
<figure class="wp-block-table"><table><tbody><tr><td>1</td><td>2</td></tr><tr><td>3</td><td>4</td></tr></tbody></table></figure>
<!-- /wp:table -->
  1. Open the post/page in the mobile app
  2. Observe that for the table block is not displaying the block's name

Expected behaviour

The missing block should display the block's name of the unsupported block.

Actual behaviour

The missing block is not displaying the block's name of all unsupported blocks.

Screenshots or screen recording (optional)

Table block Bottom-sheet displayed after tapping

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 8 (simulator)
  • Operating system: iOS 14.2
  • WordPress app version: develop
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 6, 2021
@hypest
Copy link
Contributor

hypest commented May 6, 2021

👋 @fluiddot , just to be sure, have you perhaps tried on Android too? I see iOS mentioned in the device info but not sure if it's iOS only. Thanks!

@mchowning
Copy link
Contributor

I tested iOS 17.3.0.20210503 beta, and it doesn't show this issue, so I think this isn't a problem we need to address for the current release. I also wasn't able to reproduce the issue on Android's 17.2 release, so it seems like this may be a very recent issue.

@fluiddot
Copy link
Contributor Author

fluiddot commented May 6, 2021

👋 @fluiddot , just to be sure, have you perhaps tried on Android too? I see iOS mentioned in the device info but not sure if it's iOS only. Thanks!

Yeah, this happens on Android too.

I tested iOS 17.3.0.20210503 beta, and it doesn't show this issue, so I think this isn't a problem we need to address for the current release. I also wasn't able to reproduce the issue on Android's 17.2 release, so it seems like this may be a very recent issue.

Right, the PR that introduced it was merged after the 1.52.0 code freeze so fortunately this won't be released to users, but we should fix it for the next version 1.53.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants