Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode Block should use a Textarea. #3154

Closed
mtias opened this issue Oct 25, 2017 · 2 comments
Closed

Shortcode Block should use a Textarea. #3154

mtias opened this issue Oct 25, 2017 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Oct 25, 2017

There are several shortcodes that need to enclose content, and an input is not enough.
@mtias mtias added [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels Oct 25, 2017
@shaunsantacruz shaunsantacruz mentioned this issue Oct 26, 2017
Merged
3 tasks
@aduth
Copy link
Member

aduth commented Oct 26, 2017

Related: #1709 (comment)

Right now, the shortcode block is a text input. It does not account for shortcodes that allow paragraphs, for example, of content. A textarea is necessary.

Further suggestion to use react-autosize-textarea: #1709 (comment)

One option could be to use an autosizable textarea which starts small, but wraps content and grows to accommodate.

@aduth
Copy link
Member

aduth commented Oct 26, 2017

Closed by #3184

@aduth aduth closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtias @aduth