Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets editor: Toolbar is not left-aligned with the selected block #31021

Closed
noisysocks opened this issue Apr 21, 2021 · 1 comment · Fixed by #31991
Closed

Widgets editor: Toolbar is not left-aligned with the selected block #31021

noisysocks opened this issue Apr 21, 2021 · 1 comment · Fixed by #31991
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

Description

The block toolbar in the Widgets screen is not left-aligned with the selected block.

Step-by-step reproduction instructions

  1. Go to Appearance → Widgets.
  2. Select any top level block in any widget area.

Expected behaviour

Block toolbar should be left-aligned with the selected block.

Actual behaviour

Block toolbar is indented.

Screenshots or screen recording (optional)

Screen Shot 2021-04-21 at 11 59 19

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Apr 21, 2021
@noisysocks
Copy link
Member Author

This happens because the selected block is a child of the Widget Area block. This means that BlockContextualToolbar applies the has-parent class which indents the toolbar. This is so that there is space for BlockParentsSelector to appear. But BlockParentsSelector never shows because Widget Area sets __experimentalParentSelector to false.

We should not apply the has-parents class if __experimentalParentSelector is set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant