-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Loop Block Improvements #30910
Comments
It could also be worth exploring a "click-through" interface like with reusable blocks in #29337 |
What do you mean here? |
I believe this is only one half of the editing consideration. The click-through will help in terms of boundaries and general selection interactions, but there is also the contents of the innerblocks (IE the actual post content) to think about. Editing the title of post B while editing post A can be quite confusing. |
@ntsekouras having a version of Query that doesn't include the inner Loop (because it doesn't need to show prev/next links nor query titles) and is called "Post List" or something similar to that, allowing us to treat Query as the building block for themes but something more familiar (like Latest Posts) for users. |
Is there any important remaining thing here that is mandatory in 5.8? Should we remove this issue from the board? |
Looking at the checklist in the initial post, there's still a fair bit of outstanding issues (or just needs an update), most importantly I would say is the edit feature. I've noticed this is still on by default, and will lead to user confusion (if I edit something in a page, I expect it to be within the context of that page, not that it changes globally on my site). Even with the extra checkboxes for "are you sure you want to update these secondary pages", they're checked by default, and I often don't second-guess the confirmation screen, I should use it for a double-check, but to me it's become "just another double-click I need to make". |
I'd like to propose the solution in #31461 (comment) for this. The use case is virtually identical. I wonder if we can decrease reliance on the confusing "inherit query from URL" option through contextual variations. Similar to what we've done with the Header / Footer template parts. When editing a post, I would never want a query to inherit from the URL. Also, the UX to display a post list relies on the user inserting a "Query" block... this is not very intuitive. I would suggest:
When editing a template, you will want the query to inherit from the URL most of the time. So we can just make that the default, and move the option to the "Advanced" panel. In fact... if we implement post-type variations as outlined above, we can probably remove this confusing option altogether. The result is:
|
I think there are still a couple of things that should be addressed before 5.8, like changing the block name, clarifying the inheritance option, and disabling editing by default. |
I put a design prototype together that explores some of these issues. Many of the concepts we've been working on for the template editor can potentially be applied here as well. Sound on: Query.block.mp4Click-through pattern for template parts and reusable blocks: #31109 Edit: I realise that a variation to display posts wouldn't support pagination, so we could simplify the structure significantly in that use case by removing the template block: |
Removing this from the 5.8 broad as I believe we got all the 5.8 targeted improvements in already. |
Feedback from the FSE Outreach Program consistently points to confusion around what settings live in the block toolbar vs the settings in the sidebar. For example, folks seem to expect the ability to change the number of items shown in the sidebar rather than the toolbar. Could an audit of these various settings (including their naming) be added to this issue to help improve the experience? |
Added prioritized items for WordPress 5.9, as the |
De-prioritized items from WP 5.9 and moved them down to the further iterations section. Because there is only a handful of improvements left, we can close this tracking issue and continue work on the specific tickets. 🚀 |
These are some notes for tracking improvements to Query block.
Prioritized for WordPress 5.8:
The "inherit query" setting is very obscure. There's a few things we need to address there:
inherit:false
#31856The other part that is tricky is the live editing. It can be super useful for some contexts but it is a bit too much as a default.
Currently the relationship between Query and Loop is still a bit confusing. I'd propose making some adjustments to the names:
Follow up iterations
Expand on the editing flow by having something similar to the isolated part or modal view as a way to edit both the template and content. Related to:
Query Loop
block from the inserter Hide theQuery Loop
block from the inserter #37081Link Settings
inspector option Conditionally show or hide inspector settings depending on other block settings #36972Query
(e.g.Next Page
) RenameQuery-
inner blocks to be more user-friendly #37079The text was updated successfully, but these errors were encountered: