Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: warning about invalid file types is not consistant #29997

Closed
glendaviesnz opened this issue Mar 18, 2021 · 2 comments
Closed

Gallery block refactor: warning about invalid file types is not consistant #29997

glendaviesnz opened this issue Mar 18, 2021 · 2 comments
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Mar 18, 2021 •
edited
Loading

Description

With gallery block refactor a user notification about uploading invalid file types is shown when trying to add invalid types to a gallery with Images, but not when dragging into an empty gallery

Step-by-step reproduction instructions

Check out the Gallery block refactor PR
Add an empty gallery
Drag a PDF file onto media placeholder - nothing happens
Add some images to the gallery
Drag a pdf again - snackbar shown about all files needing to be image formats

Expected behaviour

User notification should be shown whenever invalid files dragged and dropped.

The message should probably be the same colour and location and all instances as well - the black snackbar bottom right is not very visible.

Screenshots or screen recording (optional)

invalid-type-warning
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 18, 2021
@glendaviesnz glendaviesnz self-assigned this Mar 30, 2021
@glendaviesnz glendaviesnz mentioned this issue Mar 30, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 30, 2021
@glendaviesnz
Copy link
Contributor Author

PR to fix #30396

@glendaviesnz
Copy link
Contributor Author

Fixed by #30396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glendaviesnz