[RNMobile] Merge release 1.48.1 to trunk #29819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore empty width attribute in columns
The editor was crashing when attempting to render a column block which contained an empty width attribute (i.e `<!-- wp:column {"width":""} -->`.
The exception occurred when accessing a property of an undefined object, so adding a default object (`|| {}`) fixes this by allowing the property to be accessed.
* Update react-native-editor changelog
* Add missing dependency to useSelect in columns block
Co-authored-by: Carlos Garcia <[email protected]>
* Release script: Update react-native-editor version to 1.46.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor CHANGELOG * [RNMobile] Add capability to bridge to show/hide audio block (#28952) * [RNMobile] Ignore column width attribute when empty (#29015) * Update react-native-editor CHANGELOG * Fixes minor changelog alignement issue * Add Stories bridge methods for iOS (#29083) Add missing bridge methods for the Stories block. The absence of these threw an error, even though Stories block isn't fully supported for iOS just yet. Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Paul Von Schrottky <[email protected]> Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: David Calhoun <[email protected]>
* Wip: Mobile RichText - Updating old value after splitting * Mobile - Fix splitting/merging issues and keyboard jumpiness on Android * Mobile - RichText - Add isIOS check for componentDidUpdate and use blockEditorStore * Mobile - RichText - Prevent onTextUpdate on Android
This reverts commit 4b9d13f.
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
This reverts commit 956cdfc.
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
jd-alexander
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
The changes here look good!
- The reverted changes that were included in the release, were reverted here since we want to keep the changes in
trunk - The iOS Story fix is present and will be brought into
trunkas well. - All necessary version bumps and release notes updates were made under the appropriate versions.
LGTM 🚢
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to merge the changes from the release
1.48.1of the react-native-editor and Gutenberg-Mobile intotrunkbranch.Apart from solving the conflicts with
trunkbranch, this PR also reverts the commit that was required for release1.48.0but that it can't be merged intotrunkbecause it could break the web version.For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3237
Checklist: