dom: Add types to focusable #29787
Merged
dom: Add types to focusable #29787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
npm Packages
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
75 tasks
tyxla
approved these changes
Mar 12, 2021
| @@ -91,6 +93,9 @@ function isValidFocusableArea( element ) { | |||
| * @return {Element[]} Focusable elements. | |||
| */ | |||
| export function find( context ) { | |||
| /* eslint-disable jsdoc/no-undefined-types */ | |||
There was a problem hiding this comment.
Such a shame those are necessary 😭
sarayourfriend
force-pushed
the
add/dom-types-focusable
branch
from
38c8c28 to
268a479
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to the
focusable.jsmodule of thedompackage.There are no runtime changes necessary for this.
Part of #18838
How has this been tested?
Typecheck passes (static analysis CI passes).
Types of changes
Non-breaking change.
Checklist: