Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent List View: Handle multi-selected blocks #29469

Closed
Copons opened this issue Mar 2, 2021 · 0 comments · Fixed by #29878
Closed

Persistent List View: Handle multi-selected blocks #29469

Copons opened this issue Mar 2, 2021 · 0 comments · Fixed by #29878
Assignees
@Copons
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@Copons
Copy link
Contributor

Copons commented Mar 2, 2021

This issue is about the Persistent List View experiment (#28637), currently only available in the Site Editor.

The List View only highlights the selected item if a single block is selected.
This happens because the BlockNavigation component uses getSelectedBlockClientId (singular), whereas multiselection relies on getSelectedBlockClientIds (plural), which returns an array of all selected blocks, whether it's just one or many.
@Copons Copons added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 2, 2021
@priethor priethor mentioned this issue Mar 10, 2021
Closed
12 tasks
@Copons Copons self-assigned this Mar 15, 2021
@Copons Copons mentioned this issue Mar 15, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Copons Copons

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Persistent List View: Add visual support for multiple selected blocks WordPress/gutenberg
1 participant
@Copons