Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Navigation: previews are rendered but not shown on smaller screens #29278

Closed
creativecoder opened this issue Feb 24, 2021 · 3 comments
Closed
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@creativecoder
Copy link
Contributor

Description

Previews of templates and content in the navigation sidebar seem to be rendering on smaller screens, even though they aren't shown.

Step-by-step reproduction instructions

  1. Open the site editor on a smaller screen
  2. Click to show the template details at the top of the screen
  3. Click "Browse all templates"
  4. Hover over a template

Expected behaviour

Nothing, really... possibly a preview, but I suspect it's better to omit this when screen space is limited.

Actual behaviour

It appears that all the network calls used to render the preview are being made, so I assume it's being rendered but isn't visible.

WordPress information

  • WordPress version: 5.6.2
  • Gutenberg version: 10.0.0
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks

Device information

  • Device: Desktop
  • Operating system: macOS
  • Browser: Firefox
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. and removed [Type] Enhancement A suggestion for improvement. labels Sep 8, 2023
@mt8
Copy link

mt8 commented Nov 14, 2023

I tested this issue. Reproduced in the latest version. It is not displayed on small screens when editing "Templates > All Archives".

WordPress information

WordPress version: 6.4.1
Gutenberg version: 17.0.2
Are all plugins except Gutenberg deactivated? Yes
Are you using a default theme (e.g. Twenty Twenty-One)? Yes Twenty Twenty-Four

@tellthemachines
Copy link
Contributor

@creativecoder is this still an issue? Clicking on the template name at top of screen no longer shows template details, and I think the former "Browse all templates" view has been replaced by "Manage templates" which seems to work reasonably well at small screen sizes:

Screenshot 2024-04-05 at 1 48 16 PM

@creativecoder
Copy link
Contributor Author

No, this doesn't appear to be an issue since the UI has changed; I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants