Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Excerpt: Read more link/button #29168

Closed
scruffian opened this issue Feb 19, 2021 · 6 comments
Closed

Post Excerpt: Read more link/button #29168

scruffian opened this issue Feb 19, 2021 · 6 comments
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

By default the excerpt block doesn't output a read more link. In the editor I see:

Screenshot 2021-02-19 at 21 26 29

But in the front end the "Read more" link isn't output.

When I edit the read more link the cursor is a pointer, but I think it should be a caret.

Also in themes we often add the post name after the read more link but hidden with the screen-reader-text class, for accessibility, so it would be good to do the same in this block.

@scruffian scruffian added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing [Block] Post Excerpt Affects the Post Excerpt Block labels Feb 19, 2021
@annezazu
Copy link
Contributor

annezazu commented Apr 16, 2021

This was also reported as part of the fifth call for testing for the FSE Outreach Program by Justin Tadlock in this article, by Susan here, by Kristen here, by Jonas here, and by Oliver here:

For the more-link, it simply did not appear on the front end. When viewing the source code, the wrapper HTML was there, but the actual text was nowhere to be found.

I did find the Read More button confusing because it looks like a button in the editor, but I couldn’t find any way to style it and it doesn’t work as a button on live. I looked for a block I could add to the query for this too, but didn’t see one.

The “Read more” button has no function. The link to the post is missing, right?

“Read more” link is not intuitively editable. There is no cursor caret displayed when clicking the link in editor, only after you start typing something. Plus it outputs HTML on front-end even if there is no text set for the “Read more” link.

It's unclear if this is meant to be a placeholder but, in the current iteration, one expects it would show up on the front end. If it's meant to be a placeholder, we should update it to make it clear that action is needed for it to work. Right now, if you do change the text of the link, it does appear on the front end as well:

Screen Shot 2021-04-16 at 12 13 04 PM

@carolinan
Copy link
Contributor

I don't think it is possible to correctly add a title after an unknown text, and there may be problems with translations.

@carolinan
Copy link
Contributor

carolinan commented Apr 19, 2021

The heading placeholder says:
Write heading...
the quote placeholder says
Write quote...
Write citation...
and the post author byline placeholder says:
Write byline...

So I think the text should be "Write read more text..."
Or "Write read more link text...

The current aria-label is "Read more link text"

Edit: Ignore all of the above, I refreshed my page and it now says " Add quote" not "Write".
See #30404

@carolinan
Copy link
Contributor

I am not able to reproduce the part where the cursor is a pointer, please confirm.

@ntsekouras
Copy link
Contributor

This seems to have been resolved with the above PR: #30959, as it makes it clearer to the user that they see a placeholder there, no? @scruffian should we close this one?

@scruffian
Copy link
Contributor Author

Yes, we can close now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

No branches or pull requests

4 participants