Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site title: Different markup in the editor and on the frontend #28997

Closed
fklein-lu opened this issue Feb 15, 2021 · 4 comments · Fixed by #29021
Closed

Site title: Different markup in the editor and on the frontend #28997

fklein-lu opened this issue Feb 15, 2021 · 4 comments · Fixed by #29021
Assignees
Labels
[Block] Site Title Affects the Site Title Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@fklein-lu
Copy link
Contributor

Description

The Site Title block is an h1 in the editor. But on the frontend it's an h1 > a. This makes it impossible to style this block in the Site Editor.

Step-by-step reproduction instructions

  1. Add a Site Title block to any template.
  2. Save the template.
  3. Preview on the frontend.
  4. See the difference.

Expected behaviour

The markup should be the same in the editor as it is on the frontend.

Actual behaviour

The markup and therefore the display is different in the editor as it is on the frontend.

Screenshots or screen recording

In the editor:
site-title-editor

On the frontend:
site-title-frontend

WordPress information

  • WordPress version: 5.6.1
  • Gutenberg version: 9.9.2
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No, using TT1
@gziolo gziolo added [Block] Site Title Affects the Site Title Block [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing labels Feb 15, 2021
@gziolo
Copy link
Member

gziolo commented Feb 15, 2021

I can confirm the issue by looking at the current implementation.

@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Feb 15, 2021
@aurooba
Copy link
Member

aurooba commented Feb 15, 2021

Just a note to say, I'm working on a fix for this. :)

@paaljoachim
Copy link
Contributor

Hi @aurooba I assigned the issue to you.

@paaljoachim
Copy link
Contributor

Do we need to backport this fix to WP 5.7.1?
@carolinan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants