Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes legacy widget data is not saved properly #28672

Closed
draganescu opened this issue Feb 2, 2021 · 3 comments
Closed

Sometimes legacy widget data is not saved properly #28672

draganescu opened this issue Feb 2, 2021 · 3 comments
Assignees
@noisysocks
Labels
[Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Woo's Products and Products by Rating widgets are saved as having 1 product visible if the default value (5) is left unmodified before saving.

image
@draganescu draganescu added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Feb 2, 2021
@draganescu draganescu changed the title Sometimes widget data is not saved properly Sometimes legacy widget data is not saved properly Feb 2, 2021
@draganescu draganescu mentioned this issue Feb 18, 2021
Closed
53 tasks
@noisysocks noisysocks removed the Needs Testing Needs further testing to be confirmed. label Apr 27, 2021
@noisysocks
Copy link
Member

When I test this I get a widget is undefined error when I press save.

@noisysocks noisysocks self-assigned this Apr 27, 2021
@noisysocks
Copy link
Member

OK I see the problem. We need to submit the widget's form when creating a new Legacy Widget as sometimes the widget's default values are encoded in the form's values. I'm not yet sure how to do that elegantly with useFormData.

@noisysocks
Copy link
Member

Closing in favour of #31249.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@draganescu @noisysocks