Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeControl problem is RTL #28252

Closed
amir2mi opened this issue Jan 15, 2021 · 3 comments · Fixed by #28279
Closed

RangeControl problem is RTL #28252

amir2mi opened this issue Jan 15, 2021 · 3 comments · Fixed by #28279
Labels
[Feature] UI Components Impacts or related to the UI component system Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@amir2mi
Copy link
Contributor

amir2mi commented Jan 15, 2021

Hi, there is a problem with RangeControl in RTL it is obvious (ThumbWrapper goes reverse):

Gutenberg range control for rtl
@amir2mi amir2mi added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 15, 2021
@amir2mi
Copy link
Contributor Author

amir2mi commented Jan 15, 2021

I do not know why but sometimes it wrongly adds "Mobile App Android/iOS" to my Gutenberg issues.

@mchowning mchowning removed the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 15, 2021
@mchowning
Copy link
Contributor

I do not know why but sometimes it wrongly adds "Mobile App Android/iOS" to my Gutenberg issues.

I'm not sure why that would happen. 🤔 I removed the label though.

@talldan talldan added [Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Jan 18, 2021
@youknowriad
Copy link
Contributor

Couuld this be related to #28221

@youknowriad youknowriad mentioned this issue Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isRTL check by loading the ltr string explilcitely WordPress/gutenberg
4 participants
@youknowriad @talldan @mchowning @amir2mi