Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Replace deprecated waitFor usage in e2e tests #28093

Closed
gziolo opened this issue Jan 11, 2021 · 0 comments · Fixed by #28360
Closed

Testing: Replace deprecated waitFor usage in e2e tests #28093

gziolo opened this issue Jan 11, 2021 · 0 comments · Fixed by #28360
Assignees
@david-szabo97
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] E2E Tests /packages/e2e-tests [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality

Comments

@gziolo
Copy link
Member

gziolo commented Jan 11, 2021

Description

In #28055 puppeteer was updated to the latest major version 5.x. It introduced a deprecation that is polluting test results:

waitFor is deprecated and will be removed in a future release. See puppeteer/puppeteer#6214 for details and how to migrate your code.

It doesn't break anything just yet but we should look into cleaning it up as it will prevent further updates of puppeteer.
@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality [Package] E2E Tests /packages/e2e-tests labels Jan 11, 2021
@gziolo gziolo changed the title Testing: Testing: Replace deprecated waitFor usage in e2e tests Jan 12, 2021
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Jan 12, 2021
@david-szabo97 david-szabo97 mentioned this issue Jan 20, 2021
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 20, 2021
@aaemnnosttv aaemnnosttv mentioned this issue Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-szabo97 david-szabo97

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] E2E Tests /packages/e2e-tests [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated waitFor in e2e tests WordPress/gutenberg
2 participants
@gziolo @david-szabo97