Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when changing spacing via text input in Spacer block #28081

Closed
fluiddot opened this issue Jan 11, 2021 · 1 comment · Fixed by #27987
Closed

Crash when changing spacing via text input in Spacer block #28081

fluiddot opened this issue Jan 11, 2021 · 1 comment · Fixed by #27987
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Jan 11, 2021

Describe the bug
While doing the sanity tests for the 1.44.0 release on iOS a crash was reported related to changing the slider setting for the spacer block via keyboard input.

To reproduce
Steps to reproduce the behavior:

  1. Add a Spacer block
  2. Tap settings gear
  3. Change spacing via text input
  4. The app throws an undefined is not a function exception and crashes

Expected behavior
Changing the spacing value via the text input shouldn't produce a crash.

Screenshots

spacer-block-crash.mp4

Editor version (please complete the following information):

  • WordPress version: 1.44.0

Smartphone (please complete the following information):

  • Device: iPhone 8 (simulator)
  • OS: 14.0
  • WordPress App Version: 1.44.0
@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 11, 2021
@fluiddot
Copy link
Contributor Author

This crash was also happening in every component that has a slider and an input box for editing block's settings, like:

  • Buttons block (Border radius setting)
  • Columns block (Column width setting)

@hypest hypest added the [Type] Bug An existing feature does not function as intended label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants