Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Remove FullscreenModeClose If Not Needed Anymore #25557

Closed
Copons opened this issue Sep 23, 2020 · 0 comments · Fixed by #26997
Closed

Site Editor: Remove FullscreenModeClose If Not Needed Anymore #25557

Copons opened this issue Sep 23, 2020 · 0 comments · Fixed by #26997
Assignees
@vindl
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@Copons
Copy link
Contributor

Copons commented Sep 23, 2020

In #25506 we have replaced FullscreenModeClose with a new NavigationToggle component, leaving the former unused.

Since that PR is a starting point for more work that could potentially change wildly in the next few days, I've asked to not remove FullscreenModeClose until we are certain it won't be needed anymore.

Let's circle back to it when the Site Editor navigation panel is in a stable condition we are happy with, and (re-)consider removing FullscreenModeClose at that point.
@Copons Copons added [Feature] Full Site Editing [Feature] Navigation Component A navigational waterfall component for hierarchy of items. labels Sep 23, 2020
@mtias mtias added the [Type] Code Quality Issues or PRs that relate to code quality label Sep 26, 2020
@vindl vindl self-assigned this Nov 16, 2020
@vindl vindl mentioned this issue Nov 16, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vindl vindl

Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: remove unused FullscreenModeClose component WordPress/gutenberg
3 participants
@mtias @vindl @Copons