-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Component: Accessibility #25259
Comments
@afercia in the other PR you mentioned explorations and discussions:
Would you be so kind to link them here, please? It would be of great help! 🙇 |
@Copons some initial discussion on the general "sidebar pattern" happened during the latest weekly accessibility meeting on Slack. A good summary of the main accessibility concerns regarding sidebars is here: https://wordpress.slack.com/archives/C02RP4X03/p1599839238147900 We didn't come to a conclusion though, I think this needs to be further discussed, also with the Design team. |
We're trying to use the Navigator on the inserter, and I'd love to be able to use a menu-like behavior of having the menu be one tab stop with arrows to move between items, and escape to return to the previous level. Is this something the @WordPress/gutenberg-components team would consider adding? I can contribute dev work if so. |
@mirka, yes, it is possible. That's what I ended up doing, but I felt like I was hooking up a bit of complexity that could have been provided by the component. I'm not sure if that's too far-reaching for the component though. It would make implementing the navigation component far easier and consistent if the component could provide arrow key and escape to go back out-of-the-box. |
I see. I don't have a strong opinion, but I guess it would depend on whether this is a common use case. There is also #60927, where we're assessing whether/how to stabilize Navigator. It might be helpful to chime in that thread with this use case — seems relevant. |
I think that |
Currently the
Navigation
component uses a waterfall navigation.When entering a child menu:
Accessibility concerns were raised in the original PR.
Since this component is currently in
__experimental
state, I've decided to merge it anyway, slating the a11y discussion to a follow up — and here we are!These are some of the concerns that we should address (cc @afercia):
Let's figure out an accessible way to create a hierarchical navigation!
EDIT: Let's have a look at the Inserter accessibility audit that presents similar challenges to this component.
The text was updated successfully, but these errors were encountered: