-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light-weight extensions #2460
Comments
Hey Joen The publish button becomes more prominent. I would probably just have the word Post and Block and remove the word Settings. |
The Settings toggle moved to the right of the publish button could help if there were no ellipsis button 🙂 . The a11y issue isn't solved yet. Ideally, a toggle that expands something should be immediately followed by the expanded "thing" in the source order. That would require to move the toggle to the last position in the sidebar and move the sidebar before the editor. Having the toggle and the expandable panel contiguous in the source order feels very natural and intuitive to keyboard and assistive technologies users, as all they need to do is continue navigating content to find the sidebar. If the toggle and the sidebar are not contiguous, then there's the need to manage focus programmatically from the toggle to the sidebar. Also, when tabbing backwards from the sidebar, I'd expect to find the toggle. Instead, I'm forced to navigate through all the post content to finally land on the toolbar and have the ability to close/open the sidebar. |
Your help is always appreciated, Andrea.
If we wanted to have an ellipsis menu for plugins, where would it have to sit in the editor bar in order to not break the above? Would it be enough if it were to the left of the cog, right of the publish button? |
Great work @jasmussen! To the point of the ellipsis menu, it would seem natural to me to put it between preview and publish. After all, it contains extensions that affect what you are doing within the post or page you are editing. It extends the options already visible in the toolbar with more things you can do before publishing. Does that make sense? The concept of a menu like that is great, it offers another hook for developers to put stuff into , without cluttering the toolbar more. 👌 |
I would love to see this implemented. I think we can reach a middle ground with the ellipsis menu, what do you think @afercia? |
@karmatosed the a11y issue here is not solved yet. Considerations from my previous comment still stand. |
Something to add into this would be a true distraction-free mode like this: I would like to work on a plugin for this, not sure about it being core. I also think as oppose to #2876 this is a true distraction free mode, enabled by this interaction. |
Closing in favor of #3330 which has more context. |
This ticket suggests a new type of light-weight editor extensions.
The ellipsis menu could hold light-weight extensions, such as:
... or indeed any other extension that might want to add actions that are global to all content on the page. These extensions would be very light-weight, and would take an action on the page, and then either present a modal with results/further actions, or be done.
Thoughts?
This issue has been edited to focus on just extensions. The rearrangement has happened separately.
The text was updated successfully, but these errors were encountered: