Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Screen: Allow for editing a menu's name #24581

Closed
shaunandrews opened this issue Aug 14, 2020 · 9 comments
Closed

Navigation Screen: Allow for editing a menu's name #24581

shaunandrews opened this issue Aug 14, 2020 · 9 comments
Assignees
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@shaunandrews
Copy link
Contributor

shaunandrews commented Aug 14, 2020

When a navigation block is selected it's toolbar should display (#24580) the menu name. Pressing on the name would allow editing:

image

@shaunandrews shaunandrews added Needs Dev Ready for, and needs developer efforts [Feature] Navigation Screen labels Aug 14, 2020
@noisysocks
Copy link
Member

Makes sense. If we have this on the block as well we can use the name for the nav element's aria-label, too, which solves #24369.

@tellthemachines
Copy link
Contributor

If we have this on the block as well we can use the name for the nav element's aria-label, too, which solves #24369.

This could work! What will be the initial state of the menu name field though? Can we make it so that it somehow prompts users to fill it in?

@aristath
Copy link
Member

I love this idea!

Can we make it so that it somehow prompts users to fill it in?

It should be possible to focus on the menu-name when the user adds a nav-block... The blinking cursor would indicate "hey, I can be changed".
Alternatively maybe a wiggly line if the title hasn't been altered, or some other familiar visual indicator that would make users click on the menu-title to change it?

@noisysocks
Copy link
Member

Could the default not just be "Navigation" or "Site navigation"?

@draganescu
Copy link
Contributor

In the navigation editor the toolbar does not show when the block is selected, the reason being that we don't have any block actions to put there. With this as the solution to renaming a menu, what would the ellipsis menu hold as items? Can we just not show that?

@shaunandrews
Copy link
Contributor Author

What will be the initial state of the menu name field though? Can we make it so that it somehow prompts users to fill it in?

Could the default not just be "Navigation" or "Site navigation"?

I'd avoid using either of those, as they could too easily be confused with the actual components rather than an obvious placeholder name.

My first though is something like "(unnamed menu)". Its very descriptive, and the parenthesis hopefully enforce that this is something that can/should be changed.

@shaunandrews
Copy link
Contributor Author

With this as the solution to renaming a menu, what would the ellipsis menu hold as items? Can we just not show that?

This has come up before. I think we could simply remove it. However, I think there could be items in there, like "Show block settings" and "Copy" at the very least.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 22, 2021

I really like the idea of being able to change the name seen in the toolbar.

One thing that came up....
Converting a block into a reusable block. At current it looks like this:

Screen Shot 2021-01-22 at 13 19 56

Clicking the name "Convert to regular block" in the toolbar will not change the name of the block but convert it back to a regular block. Which means we should likely change how this functions today. Move the Reusable block name back into the toolbar and have it work in the same method as is being discussed in this issue. (I smell a new issue coming up....:) Hmm I should probably wait with the issue until the idea (edit name in toolbar) is merged into the Gutenberg plugin.

@shaunandrews
Copy link
Contributor Author

This has been superseded by #28864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants