-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Screen: Allow for editing a menu's name #24581
Comments
Makes sense. If we have this on the block as well we can use the name for the |
This could work! What will be the initial state of the menu name field though? Can we make it so that it somehow prompts users to fill it in? |
I love this idea!
It should be possible to focus on the menu-name when the user adds a nav-block... The blinking cursor would indicate "hey, I can be changed". |
Could the default not just be "Navigation" or "Site navigation"? |
In the navigation editor the toolbar does not show when the block is selected, the reason being that we don't have any block actions to put there. With this as the solution to renaming a menu, what would the ellipsis menu hold as items? Can we just not show that? |
I'd avoid using either of those, as they could too easily be confused with the actual components rather than an obvious placeholder name. My first though is something like "(unnamed menu)". Its very descriptive, and the parenthesis hopefully enforce that this is something that can/should be changed. |
This has come up before. I think we could simply remove it. However, I think there could be items in there, like "Show block settings" and "Copy" at the very least. |
I really like the idea of being able to change the name seen in the toolbar. One thing that came up.... Clicking the name "Convert to regular block" in the toolbar will not change the name of the block but convert it back to a regular block. Which means we should likely change how this functions today. Move the Reusable block name back into the toolbar and have it work in the same method as is being discussed in this issue. (I smell a new issue coming up....:) Hmm I should probably wait with the issue until the idea (edit name in toolbar) is merged into the Gutenberg plugin. |
This has been superseded by #28864 |
When a navigation block is selected it's toolbar should display (#24580) the menu name. Pressing on the name would allow editing:
The text was updated successfully, but these errors were encountered: