Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.5:Preview window does not reload automatically with post updates #24562

Open
ddryo opened this issue Aug 13, 2020 · 2 comments
Open

5.5:Preview window does not reload automatically with post updates #24562

ddryo opened this issue Aug 13, 2020 · 2 comments
Labels
[Feature] Saving Related to saving functionality [Type] Regression Related to a regression in the latest release

Comments

@ddryo
Copy link
Contributor

ddryo commented Aug 13, 2020

Thank you for your development.
With the 5.5 update, Gutenberg is even better.

However, I have one thing to ask, so I would like to ask you a question.

The preview window opened in "Preview in new tab" no longer reloads automatically when the post is updated.

Is this normal behavior from 5.5?
Is it changed for some reason?

I'm sad that automatic reload was so convenient.

If it's a bug, I hope it will be fixed...

@Computerbuddha
Copy link

Same issue here. Hope it´s a bug. Also now you have two (instead of one) clicks for the preview: 1. "Preview" -> Popup -> 2. "Preview in a new tab".

@talldan talldan added [Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release and removed [Type] Bug An existing feature does not function as intended labels Aug 18, 2020
@talldan
Copy link
Contributor

talldan commented Aug 18, 2020

@ddryo Thanks for reporting this, it does indeed seem to be a bug/regression in v5.5. I think the problem is the behavior is tied to the visibility of the 'Preview in new Tab' button. If you leave the new Preview menu open, then save a change, you'll notice the preview does update like it used to.

What seems to be happening is that previewWindow is undefined here:
https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/post-preview-button/index.js#L131-L132

The component must be losing it's reference to previewWindow when umounted.

@Computerbuddha There's a separate issue for the two clicks - #24584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants