Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons border radius is not defaulting correctly #24128

Closed
mapk opened this issue Jul 22, 2020 · 5 comments
Closed

Buttons border radius is not defaulting correctly #24128

mapk opened this issue Jul 22, 2020 · 5 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Jul 22, 2020

Describe the bug
When adding a button to the Buttons block, the default corner radius shows 5. But when I make an adjustment to corner radius of 5, the corners change drastically. So the default setting isn't reflecting the actual radii.

To reproduce
Steps to reproduce the behavior:

  1. Add a Buttons block
  2. If using the Gutenberg-starter-theme, notice the default styling is completely rounded corners.
  3. Observe the radius setting default only shows 5.
  4. Change the radii and view the results.

Expected behavior
I expect the default radius in the settings sidebar to match the actual radii of the button corners.

Screenshots

radius

Editor version (please complete the following information):

  • WordPress version: 5.4
  • Gutenberg version: 8.5
  • Chrome latest version
@mapk mapk added [Type] Bug An existing feature does not function as intended [Block] Buttons Affects the Buttons Block labels Jul 22, 2020
@mapk
Copy link
Contributor Author

mapk commented Jul 22, 2020

I tested this on Twenty Twenty too. Same issue.

radius-problem

@CreativeDive
Copy link
Contributor

@mapk I think how the default button looks is a theme decision. The best option would be a disabled border radius by default. Only if we change the radius, this should be affects the button. Because buttons could be squared or can have a larger radius by default theme settings.

@youknowriad
Copy link
Contributor

Seems like there's a couple of related issues #17596 #4420

@mapk
Copy link
Contributor Author

mapk commented Jul 23, 2020

I think how the default button looks is a theme decision.

Yes. I don't have any problem with there being various radii. The problem is that the numeric value isn't reflected in the settings. If the border-radius for a theme's button style is 50, it should be reflected in the settings. If it's 0, it should be that value.

@mapk
Copy link
Contributor Author

mapk commented Jul 23, 2020

I'm going to close this in favor of #17596 and move my comments here to there.

@mapk mapk closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants