Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Limit the text width #24106

Open
alaczek opened this issue Jul 22, 2020 · 1 comment
Open

Media & Text: Limit the text width #24106

alaczek opened this issue Jul 22, 2020 · 1 comment
Labels
[Block] Media & Text Affects the Media & Text Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@alaczek
Copy link

alaczek commented Jul 22, 2020

Is your feature request related to a problem? Please describe.
The width of the text placed in the Media & Text block is not limited in any way. This leads to an uncomfortably long line-length in higher browser widths. There are workarounds for this issue, for example nesting the text in a columns block, but these are hacky and force a needlessly complicated block structure that can be hard to navigate.

Describe the solution you'd like
I mostly wanted to start a discussion around this topic to figure out a solution together. Here are some of my rough ideas:

  • make a regular/wide/full width setting just for the text portion of the block
  • add padding controls similar to the ones in the Cover block
  • make this a theme responsibility

Here's a visual example of the line-length issue.

At 1280px browser width:
image

At 1920px browser width:
image

@mapk
Copy link
Contributor

mapk commented Jul 22, 2020

I've experienced this same thing and resorted to using Columns inside. It's definitely worth a Design Tool exploration. I know paddings are being worked on by @ItsJonQ for the Cover block, maybe those learnings can help here?

@mapk mapk added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Media & Text Affects the Media & Text Block labels Jul 22, 2020
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants