Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Screen of WTF just happened #2410

Closed
aaronjorbin opened this issue Aug 14, 2017 · 10 comments
Closed

White Screen of WTF just happened #2410

aaronjorbin opened this issue Aug 14, 2017 · 10 comments
Labels
[Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@aaronjorbin
Copy link
Member

Gutenberg 0.8
Chrome 60.0.3112.90

I clicked on the plus sign below the content and suddenly everything went away. Here is the error in my console:

https://cloudup.com/cWzWPHcgv_4

This caused me to lose content 😢

Where did my content go and why did Gutenberg go away?

@karmatosed
Copy link
Member

Crumbs that isn't good. I am not getting it using the latest version. I do wonder if it could be related to an issue where pull quotes were white screening. @youknowriad - sorry to ping but wondering if you can shed some light here?

@aaronjorbin
Copy link
Member Author

We should also consider how to:

  1. Ensure there are quality error messages and stack traces, especially while we are in active development. This may mean not minifying the code.
  2. How do we ensure this never happens, even after developers extend Gutenberg?

@aduth
Copy link
Member

aduth commented Aug 14, 2017

#2267 can serve as an example of capturing and recovering from runtime errors, specifically those occurring in React component using new error handling features included in React 16.

I think we need to be more liberal with how we apply this pattern, and further perhaps with catching errors generally.

In a worst case, we could have a copy of the post state persisted in a local cache (indexedDB, localStorage) and recover from this when revisiting the editor.

@aduth
Copy link
Member

aduth commented Aug 14, 2017

Are you able to reproduce this issue consistently?

@aaronjorbin
Copy link
Member Author

In a worst case, we could have a copy of the post state persisted in a local cache (indexedDB, localStorage) and recover from this when revisiting the editor.

This is something we should no matter what. If Gutenberg ends up in core, not having this would be a regression over the current editor.

@aaronjorbin
Copy link
Member Author

Are you able to reproduce this issue consistently?

I'm not, but I only spent a few moments trying to do so thus far. It has happened to me once or twice before though.

@aduth
Copy link
Member

aduth commented Aug 14, 2017

The first error is from the Grammarly extension. Might be an incompatibility.

@mtias
Copy link
Member

mtias commented Aug 14, 2017

For reference, core pushes posts to sessionStorage (not localStorage) as wp-autosave-{x}: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/autosave.js#L144

@aaronjorbin
Copy link
Member Author

I noted another issue where Gutenberg was having a problem with Grammarly in #2113. The extension was also brought up in #1698.

@aduth aduth added [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. labels Aug 25, 2017
@karmatosed
Copy link
Member

I think we can close this? Going to cautiously do that :) If that's not the case, lets reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

4 participants