Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow section wrapper blocks to specify open and closing HTML tags #23541

Closed
glenviewjeff opened this issue Jun 28, 2020 · 3 comments
Closed
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@glenviewjeff
Copy link

glenviewjeff commented Jun 28, 2020

To solve the problem of being unable to surround multiple blocks by HTML, for instance a hyperlink anchor, add opening and closing markup tags for section blocks. It's unclear if this is the same request.

What spurred this is receiving a mobile usability warning about hyperlinks being too close together from Google Search Console. I have multiple hyperlinks to the same destination in a group of blocks.

@glenviewjeff glenviewjeff changed the title Allow section blocks to specify open and closing HTML tags Allow section wrapper blocks to specify open and closing HTML tags Jun 28, 2020
@talldan
Copy link
Contributor

talldan commented Jun 30, 2020

@glenviewjeff Something similar was discussed on #20997, with the idea that the group block could offer more semantic variations, like section or footer. That was also explored in a pull request - #20218.

I don't think it'd work for your use case, as the group block doesn't have any link/href functionality.

#15794 also seems somewhat related, as that requests a way to wrap arbitrary HTML around blocks.

@glenviewjeff
Copy link
Author

glenviewjeff commented Jun 30, 2020

Yes, it seems we need the ability to somehow wrap HTML around blocks, however its achieved.

For now, it's ugly, but I'm able to work around this by surrounding the blocks I want hrefs applied to with custom HTML blocks, but when I return to edit the page, Gutenberg complains that "this block contains unexpected or invalid content" because the tags aren't closed. I think that's what #15794 is referring to?

image

@talldan
Copy link
Contributor

talldan commented Jul 1, 2020

Yep, that's the same issue as #15794.

As there are two other open issues covering the same topic as this one, I'll close this as a duplicate.

@talldan talldan closed this as completed Jul 1, 2020
@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants