Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy widget preview may not work as expected because it lacks front end assets #22838

Closed
jorgefilipecosta opened this issue Jun 2, 2020 · 1 comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended

Comments

@jorgefilipecosta
Copy link
Member

Describe the bug
Some widgets have a backend UI on the widget screen but don't provide the scripts/styles that render that content on the frontend.
In the editor, we don't load all the frontend assents so the preview may not work as expected.

A possible solution is to render the widget previews on an iframe with all the frontend assets.
PR #14643 implemented this solution but did not get much traction.

To reproduce
I installed https://wordpress.org/plugins/instagram-slider-widget/
I tested the widget with an Instagram hashtag and verified the widget preview does not contain the slider UI that appears on the frontend.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Package] Edit Widgets /packages/edit-widgets labels Jun 2, 2020
@noisysocks
Copy link
Member

May be fixed by #14643.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants