Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to fill out caption before image upload #22294

Closed
ellatrix opened this issue May 12, 2020 · 3 comments · Fixed by #22295
Closed

Possibility to fill out caption before image upload #22294

ellatrix opened this issue May 12, 2020 · 3 comments · Fixed by #22295
Assignees
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ellatrix
Copy link
Member

Sometimes, I'd like to write a page and lay it out before uploading images. It would be nice if I could fill out caption in image placeholders before uploading the images. It also lets me remember what to upload as the caption is a clue.

I realise this may conflict with inserting an image from the media library that already has a caption, but imo the caption written in the block should then be kept.

@ellatrix ellatrix added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block labels May 12, 2020
@ellatrix
Copy link
Member Author

Cc @mtias

@ellatrix
Copy link
Member Author

To be honest, we currently have logic in place that overrides the user written caption with the media library caption if you replace the image. This is wrong. We shouldn't discard the caption?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 12, 2020
@draganescu
Copy link
Contributor

I clearly remember working on the gallery block for preserving the captions in the editor. I think the idea was:

  • caption in editor are not replaced by captions in the media library
  • empty captions in the editor are replaced by captions in the media library
  • captions in the editor can be replaced by captions in the media library if they're edited before image is inserted (replaced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants