Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At checked "Pending review", generate unintentional revision #22259

Closed
akiya64 opened this issue May 11, 2020 · 2 comments
Closed

At checked "Pending review", generate unintentional revision #22259

akiya64 opened this issue May 11, 2020 · 2 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. [Type] Bug An existing feature does not function as intended

Comments

@akiya64
Copy link

akiya64 commented May 11, 2020

At checked "Pending review", generate unintentional revision by showing Preview.

To reproduce

  1. Create post with Custom Fields.
  2. Check "Pending review".
  3. Edit contents or custom fields.
  4. Show preview by click "Preview" button.
  5. Move dashboard and editing same post again, or reload page after click "Preview".
  6. Generated new "auto save", inclements revision but I did not change contents.

Expected behavior

I want not generate new revision, if contents has no change.
On WP5.4.0, generated new "auto save" by showing preview avoid all custom fields.
So I hope that keep custom fields at checked "pending review".
On WP 5.4.1 it seems keep custom fields in generated revision by showing Preview.

Screenshots

At reproduce step 6.
2020-05-11_17h03_25

2020-05-11_17h37_39

Editor version

  • WordPress version: 5.4.1
  • default Gutenberg

Desktop

  • OS: Windows 10 Pro 1903
  • Browser FireFox
  • Version 76.0.1
@annezazu annezazu added [Feature] History History, undo, redo, revisions, autosave. Needs Testing Needs further testing to be confirmed. labels May 12, 2020
@peterwilsoncc peterwilsoncc added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Oct 13, 2020
@peterwilsoncc
Copy link
Contributor

This was able to be reproduced in a triage session today.

As in the screen shot above, it's reproducible without a custom fields plugin/custom meta boxes and occurs with WP Core's custom fields.

@talldan mentioned it may be because the custom fields form prevents Gutenberg from knowing if the post is dirty so generates an autosave whenever the preview button is pressed.

@akiya64
Copy link
Author

akiya64 commented Jun 23, 2021

I was re-attacked this issue in WordCamp Japan 2021 contributer day.
I tested in WordPress 5.7.2 and Gutenberg latest trunk again, this problem is not reploduce.

I found PR, Fix unexpected autosave for published posts by youknowriad · Pull Request #27942 in Gutenberg 9.8.0 release note.
Maybe this issue was fixed by that PR.

Related issue #27939

@akiya64 akiya64 closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants