Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List block: explore dropdowns. #21477

Closed
jasmussen opened this issue Apr 8, 2020 · 10 comments
Closed

List block: explore dropdowns. #21477

jasmussen opened this issue Apr 8, 2020 · 10 comments
Labels
[Block] List Affects the List Block Needs Design Feedback Needs general design feedback.

Comments

@jasmussen
Copy link
Contributor

The List block looks like this:

Screenshot 2020-04-08 at 10 58 44

So as to optimize and group items, we should explore collapsing the list type and tools in dropdowns, like so:

Screenshot 2020-04-08 at 11 02 03

This would also potentially afford some interesting additional list types, like ordered with letters.

@jasmussen jasmussen added the Needs Design Feedback Needs general design feedback. label Apr 8, 2020
@jasmussen jasmussen changed the title Resize handles: Explore tall handles List block: explore dropdowns. Apr 8, 2020
@jasmussen
Copy link
Contributor Author

As you can see from my ticket rename, I was originally drafting a different ticket ;)

@paaljoachim
Copy link
Contributor

Companion issue: #17738

@karmatosed
Copy link
Member

I think exploring any reduction to drop-downs for the toolbar makes sense. It also benefits all screen sizes and reduces cognitive load.

@skorasaurus skorasaurus added the [Block] List Affects the List Block label Nov 23, 2020
@paaljoachim
Copy link
Contributor

This is a very good idea!
We have the list type options as primary options directly in the toolbar.

@mapk
Copy link
Contributor

mapk commented Dec 1, 2020

I noticed in the description that the toolbar isn't reflecting the list type chosen.

Screen Shot 2020-12-01 at 12 56 17 PM

I'm guessing this is an oversight, and it would look like this:

Screen Shot 2020-12-01 at 12 59 24 PM

@mapk
Copy link
Contributor

mapk commented Dec 1, 2020

I'll also note that the icons there are really starting to look too similar. In the Figma library, they look like this:

Screen Shot 2020-12-01 at 1 03 26 PM

The Figma options feel different enough to provide an easier understanding.

@richtabor
Copy link
Member

Had some thoughts here. The > < buttons are an action you do multiple times perhaps, I'm not 100% that they should be in the dropdown. To indent a list item, you'd need to click on the icon, then click the correct dropdown item - instead of currently where you can move it in and out quickly.

@paaljoachim
Copy link
Contributor

paaljoachim commented Dec 1, 2020

Here is an example from the Image block alignment controls.

Screen Shot 2020-12-01 at 22 10 20

We can take out the alignment icons and put in list type icons when used in the List block.
Giving users the option to switch between various List icons just in a similar way to how one switches between alignment options.

@jasmussen
Copy link
Contributor Author

Eagle eyes. Thankfully the icons have already been updated in the code, to this:

Screenshot 2020-12-02 at 08 50 11

Additionally in revisiting this, I'd remove the separator between the two items as they are related:

Untitled-1

Had some thoughts here. The > < buttons are an action you do multiple times perhaps, I'm not 100% that they should be in the dropdown. To indent a list item, you'd need to click on the icon, then click the correct dropdown item - instead of currently where you can move it in and out quickly.

Is this an often enough occurrence that it needs separate buttons vs. be grouped in the dropdown?

@jasmussen
Copy link
Contributor Author

In light of the List block receiving nesting, I'm going to close this one as essentially obsolete. There are still aspects of the conversation here that may be relevant, so they're crosslinked from the nesting work in #39605 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

6 participants