Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing: home page indicator #20788

Closed
mtias opened this issue Mar 11, 2020 · 8 comments · Fixed by #22004
Closed

Site Editing: home page indicator #20788

mtias opened this issue Mar 11, 2020 · 8 comments · Fixed by #22004
Assignees
Labels
Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Mar 11, 2020

We should add an icon to indicate what is currently set as the home template:

image

The order should reflect some hierarchy as well, with home page / front page being always at the top.

And also need to start thinking about the site setting and how it interacts with the blog being set as home or on a sub-path.

@MichaelArestad
Copy link
Contributor

Does this need to be reflected here or in something like a template manager? I could also envision a Template "tab" next to Document and Blocks in the sidebar that displays information about the template like theme, pages using it, template parts.

@epiqueras
Copy link
Contributor

We need something like that, but wouldn't a home icon in the template switcher also be a good addition?

@MichaelArestad
Copy link
Contributor

Here's a mockup by @joanrho that does the job:

image

Some questions:

  • Is it enough of an indicator?
  • Does it need an explanation (perhaps in the template preview on hover)?

For now, I think it's definitely a good start.

SVG code:

<svg width="10" height="10" viewBox="0 0 10 10" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M9.5 4V9.5H6.75V6.25V5.75H6.25H3.75H3.25V6.25V9.5H0.5V4L5 0.625L9.5 4Z" fill="black" stroke="black"/>
</svg>

@epiqueras
Copy link
Contributor

Yes, a tooltip on the icon would suffice, right?

@joanrho
Copy link
Contributor

joanrho commented Apr 30, 2020

A tooltip with text along the lines of "Current Home page template" could be helpful since the template name could be anything. Or, would it communicate better if it were a line of text at the very top of the Template Preview pane, since that preview appears alongside each template on hover over template name?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 30, 2020
@MichaelArestad
Copy link
Contributor

Yes, a tooltip on the icon would suffice, right?

Totally. As long as it plays nicely with the menu.

"Current Home page template"

Right! Perhaps a slightly shorter version: "Home page template"

@epiqueras
Copy link
Contributor

@MichaelArestad See #22004

@mtias
Copy link
Member Author

mtias commented May 1, 2020

Commented on the PR, but we should not introduce another baseline icon grid of 10/10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants