Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving dropdown menus for family of tools in the Toolbar #20761

Open
mtias opened this issue Mar 10, 2020 · 5 comments
Open

Improving dropdown menus for family of tools in the Toolbar #20761

mtias opened this issue Mar 10, 2020 · 5 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Mar 10, 2020

We have several groups of tools — block alignment, text alignment, vertical alignment, heading level — that are displayed very verbosely at the moment with icon + text:

image

The proposed design update of the toolbar aims to make them the same size as the toolbar control the spring from:
image

(Obviously they will have tooltips just like the regular toolbar items.)

We should also ensure that it opens consistently to the bottom and only to the top when there is no space. Right now it seems to have no coherence.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system labels Mar 10, 2020
@ZebulanStanphill
Copy link
Member

Would this be an okay thing to do, accessibility-wise?

@chrisvanpatten
Copy link
Contributor

I'll be honest I don't love the look without the labels. I definitely think the positioning of the "dropdown" could be improved (should ideally have the left edge aligned with the left edge of the "button"), but the icons are all a bit too similar to my eyes to easily scan without the text. It's just hard to quickly scan and find what you're looking for.

@mtias
Copy link
Member Author

mtias commented Mar 13, 2020

It'd actually be consistent with other toolbar icons which is icon button + tooltip. It's a very common pattern, what we are doing right now feels super idiosyncratic:

image

@chrisvanpatten
Copy link
Contributor

I feel like that's not the best example because text alignment icons are much more "scannable" and arguably ingrained in the public consciousness to a degree. The Gutenberg block position icons aren't as visually distinct or commonly understood.

The Google example also has the benefit of setting the active icon in a different color. In G2 UI, the active icon is still black and white. Inverted, yes, but difficult to separate visually because it uses the same colors.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 16, 2023
@mtias
Copy link
Member Author

mtias commented Sep 29, 2024

Closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants